Skip to content

[Payment due @ZhenjaHorbach] [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started - #106714

Merged
MonilBhavsar merged 6 commits into
mainfrom
georgia-wise-dismiss-banners-after-form
Nov 13, 2026
Merged

MonilBhavsar merged 6 commits into
mainfrom
georgia-wise-dismiss-banners-after-form

Conversation

@grgia

@grgia grgia commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

get-started-main-vs-intro-read.mp4

The business details form for Wise global reimbursements now opens straight after Get started, without a spinner in the usual case.

Get started dismissed the Wallet and Workspace banners before opening the form. The form waits for the business details from OpenReimbursementAccountPage, and that read was held until both dismissals had finished, one after the other. The intro page now starts that read when it opens, and the banners are dismissed once the form has opened. Dismissing them for good when onboarding starts is deliberate and kept.

  • Was about 2.4s on dev
  • Immediate click or direct link: one request, about 1s
  • The read keeps the bank account setup draft
  • Continue to the status page still dismisses the banners
  • Banners stay if the admin leaves before the form opens
  • Tests cover the intro read, its reuse, and the fallback

PREVIOUS COMMIT VIDEO (DISREGARD)

https://github.com/user-attachments/assets/59a50af9-3aa3-44fd-b2a3-9d9e3d3ecde5

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/703270
PROPOSAL:

Tests

Needs the wiseReimbursements beta and a USD business bank account that has not started Wise onboarding.

  1. Open Account > Wallet.
  2. Open the browser Network tab and filter on api.
  3. Click the bank account, then Enable Global Reimbursements.
  4. Verify OpenReimbursementAccountPage is sent when the intro page opens.
  5. Wait for it to return, then click Get started.
  6. Verify the business details form opens without a spinner.
  7. Verify no second OpenReimbursementAccountPage is sent.
  8. Verify two DismissProductTraining requests are sent after the form opens.
  9. Go back to Wallet and verify the global reimbursements banner is gone.
  10. Open the form again, click Next, then go back a page.
  11. Verify no more DismissProductTraining requests are sent.
  12. Reload the page on the form's URL.
  13. Verify a spinner shows, one OpenReimbursementAccountPage is sent, then the form opens.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open the intro page for the bank account and wait for OpenReimbursementAccountPage to return.
  2. Go offline.
  3. Click Get started.
  4. Verify the form opens with the business details filled in.
  5. Go back online.
  6. Verify the form stays open.

QA Steps

Same as tests, on an account with the wiseReimbursements beta.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

grgia added 3 commits November 9, 2026 17:10
…om the intro

API.read waits for the sequential write queue to drain, so the two
DismissProductTraining writes queued by Get started held the page's
OpenReimbursementAccountPage read, and its loader, for two extra round
trips. The dismisses now fire from the business details page once the
form has rendered on a new visit for an eligible account.
The business details page already holds several inline effects for
unrelated concerns, so the banner dismissal lives in
useDismissWiseGlobalReimbursementsBanners and the page only calls it.
@grgia
grgia requested a review from ZhenjaHorbach November 12, 2026 12:13
@grgia
grgia marked this pull request as ready for review November 12, 2026 12:13
@grgia
grgia requested review from a team as code owners November 12, 2026 12:13
@grgia grgia changed the title [Wise][Business Onboarding][Fix] Open the business details form without waiting on banner dismissals [NO QA][Wise][Business Onboarding][Fix] Open the business details form without waiting on banner dismissals Nov 12, 2026
@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team November 12, 2026 12:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T12:17:43.527303Z 5a961b4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from MonilBhavsar and removed request for a team November 12, 2026 12:14
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a961b4025

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

The business details form waited on OpenReimbursementAccountPage after
Get started. The intro page now starts that read while it is in focus
and records which bank account it is for, so the form opens on those
details and only reads for itself on a direct link or another account.
Both reads keep the bank account setup draft.

Continue to the status page dismisses the banners again, since only the
form dismissed them after the earlier commit.
The action and hook are named after OpenReimbursementAccountPage, and
the in-memory key says it holds a bank account ID.
@grgia grgia changed the title [NO QA][Wise][Business Onboarding][Fix] Open the business details form without waiting on banner dismissals [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dylanexpensify
dylanexpensify removed their request for review November 12, 2026 14:31
@ZhenjaHorbach

ZhenjaHorbach commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-12.at.19.01.07.mov
Android: mWeb Chrome
Screen.Recording.2026-11-12.at.19.01.07.mov
iOS: HybridApp
Screen.Recording.2026-11-12.at.19.01.07.mov
iOS: mWeb Safari
Screen.Recording.2026-11-12.at.19.01.07.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-12.at.18.59.39.mov

…t's details

The record is set before the request and stays after a failed read, so
the form skipped its own read and could open without the business
details. It now reads for itself unless the intro's read is still
running or the details on the device are for this bank account.
@grgia
grgia requested a review from dariusz-biela November 12, 2026 17:26
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Changes look good!

@melvin-bot melvin-bot Bot changed the title [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started [Payment due @ZhenjaHorbach] [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started Nov 12, 2026
@melvin-bot

melvin-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/703270.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

BUG: unable to access in-progress bank account setup on this build

I logged into this Adhoc build in an account that had a bank account that was partway through the Wise onboarding flow. When I tap the "Continue" button to try to continue with the form where I was, the loading screen just hangs, and I'm unable to access the form.

I did try in an account that did not have a partially set up bank account, where I started the Wise onboarding experience from the beginning, and it is working as expected there. See below for two comparison videos.

Partially setup wise flow

2026-11-12_14-26-13.mp4

Starting wise flow from beginning

2026-11-12_14-33-12.mp4

@ZhenjaHorbach

ZhenjaHorbach commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Works as expected for me with Partially setup wise flow
But it's probably because adhoc build without the latest changes 😅

Screen.Recording.2026-11-12.at.20.49.00.mov

@grgia

grgia commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author

@joekaufmanexpensify found it, thanks for the two videos. That bank account has source of wealth answers saved from the EDD PR yesterday, and main can't read those yet, so the form never opens. It's not from this PR, the EDD PR is what teaches it to. Can you retest with a partway account that hasn't been through the EDD pages?

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Ah, okay, that makes sense. Nice find. I'll retest with a different account now. 👍

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Yep, confirmed working well in a different account that had an existing partially completed Wise onboarding flow. 👍

2026-11-13_08-25-33.mp4

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@MonilBhavsar
MonilBhavsar merged commit 8909de8 into main Nov 13, 2026
48 of 51 checks passed
@MonilBhavsar
MonilBhavsar deleted the georgia-wise-dismiss-banners-after-form branch November 13, 2026 13:50
@github-actions

Copy link
Copy Markdown
Contributor

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only improves loading performance within the existing beta-gated Wise onboarding flow, without changing documented steps or releasing the beta.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants